I expect this to turn into a flamewar, so I'm going to ask everyone to only give one opinion (voting style). Please please please don't fight about this.
I just got back from PyCon, and there was a presentation there on pep 8 formatting, and one of the main points was that pure formatting PRs mess up the history (git blame no longer shows who last made a non-trivial change). The proposed solution would be to only fix formatting in areas where you're also making a non-trivial change. For example, say I make a tiny bug fix in function foo - I could also clean up some of the code in foo. That way the last person to touch foo is not someone who added a space between an operator, but someone who actually changed the functionality of foo. This is not to bash people who do formatting fixes - they are highly valuable, it's just saying that formatting (IMO) should be done incrementally as we improve the codebase, not as just formatting PRs. (docs are an exemption from this, as formatting can be thought of as a functional change). Thoughts??? -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To post to this group, send email to sympy@googlegroups.com. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/5fe1f28a-9ac0-42db-882a-b8ed0a0f5080%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
