I watched Raymond's talk but didn't come away thinking that we should merge formatting and functionality edits. That seems to cloud the history even more. With git blame you can see the commit message and if it says "formatting", then you need to git blame before that commit to see who actually wrote it.
I think the main take away from the talk is just "don't be super strict with pep8". Which he could've said in a much briefer way. BTW, I thought Raymond's talk was really poor. That seemed like an example of an ill prepared talk that dragged on for an hour. I suspect he got the talk spot because he's well known and then didn't really put much effort into it. Jason moorepants.info +01 530-601-9791 On Tue, Apr 14, 2015 at 10:54 AM, James Crist <crist...@umn.edu> wrote: > I expect this to turn into a flamewar, so I'm going to ask everyone to > only give one opinion (voting style). Please please please don't fight > about this. > > I just got back from PyCon, and there was a presentation there on pep 8 > formatting, and one of the main points was that pure formatting PRs mess up > the history (git blame no longer shows who last made a non-trivial change). > The proposed solution would be to only fix formatting in areas where you're > also making a non-trivial change. > > For example, say I make a tiny bug fix in function foo - I could also > clean up some of the code in foo. That way the last person to touch foo is > not someone who added a space between an operator, but someone who actually > changed the functionality of foo. > > This is not to bash people who do formatting fixes - they are highly > valuable, it's just saying that formatting (IMO) should be done > incrementally as we improve the codebase, not as just formatting PRs. (docs > are an exemption from this, as formatting can be thought of as a functional > change). > > Thoughts??? > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sympy+unsubscr...@googlegroups.com. > To post to this group, send email to sympy@googlegroups.com. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/5fe1f28a-9ac0-42db-882a-b8ed0a0f5080%40googlegroups.com > <https://groups.google.com/d/msgid/sympy/5fe1f28a-9ac0-42db-882a-b8ed0a0f5080%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To post to this group, send email to sympy@googlegroups.com. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAP7f1AgAgvD0u0hq8YjQjnrXX7yaqXPMQNBUOa6zFukbNjM%3D%3Dg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
