I have shared draft of my proposal with Sympy. Its in PDF format . Mentors please check it out and let me know about your suggestions - https://github.com/sympy/sympy/wiki/GSoC-2019-Current-Applications
On Wed, Mar 20, 2019 at 7:01 PM Jogi Miglani <jmig5...@gmail.com> wrote: > I had also tried a different approach i.e more general for handling > modular equations locally. That was facing some issue. I will also be > making a PR to get more of your suggestions. More tests I will be adding to > it. > > On Wed, Mar 20, 2019 at 6:17 PM Yathartha Joshi <yatharth...@gmail.com> > wrote: > >> Yeah, you can but if you wish to use the code written by someone else, >> then you should cherry-pick the commits and then continue your work. In >> this way the authorship is maintained. >> >> Cheers! >> Yathartha Joshi >> >> On Wednesday, March 20, 2019 at 4:29:47 PM UTC+5:30, Kunal Sharma wrote: >>> >>> I was trying to implement modular equations in solveset, issue #13178 >>> <https://github.com/sympy/sympy/issues/13178>. Looking at the PR #14284 >>> <https://github.com/sympy/sympy/pull/14284>, most of the work has >>> already been done by @ishanaj, but it looks like that the work has stalled. >>> I would like to help in merging the PR. So should I just make a new PR with >>> imrovements that are asked by @normalhuman >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "sympy" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to sympy+unsubscr...@googlegroups.com. >> To post to this group, send email to sympy@googlegroups.com. >> Visit this group at https://groups.google.com/group/sympy. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/sympy/ea674097-1584-450d-a501-e963bb0ae80b%40googlegroups.com >> <https://groups.google.com/d/msgid/sympy/ea674097-1584-450d-a501-e963bb0ae80b%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To post to this group, send email to sympy@googlegroups.com. Visit this group at https://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAGPLj22jyn78ttGFVtyRHOA6em%2B5YHM29ouTcbdd%2Bnxcc4_chA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.