In general I question whether things like this need to be part of the main sympy project rather than as another project on pypi that can be installed separately. If we are going to include domain-specific modules that are really just built on top of sympy then I think that it is important that they are in some way contributing to the rest of sympy.
For example the work that goes into creating this package could also involve making improvements to things like dsolve and lambdify for solving ODEs and analytically and numerically. The PR right now has its own implementation for those things which I don't think is right. If we need improvements to lambdify and dsolve so that they are more useful for control theory then we should make those improvements which will be of more general use than the control theory package itself. Oscar On Mon, 3 Feb 2020 at 13:58, Naman Nimmo <namanger...@gmail.com> wrote: > > Hi Everyone, > I'm Naman Gera, from the Electronics and Communication Engineering department > at the Indian Institute of Information Technology, Guwahati. > > I started contributing to Sympy in December 2019 and ever since then, I've > learned so many things. I have immense respect for this brilliantly talented > open source community. They are some of the best coders I have seen, > developing open-source (even on weekends!) because they believe in it. I have > raised several PRs so as to solve some issues, and after each new PR, I > learned something new and also understood that particular part of code. > > This summer, I would like to work on adding a control package to > sympy.physics. > > > Initially, I would try to complete the work started in #17866 > I'll get the already implemented methods polished for merging. > > > After setting up the base classes (which are `StateSpaceModel` and > > `TransferFunctionModel`), I'll add some other methods like > > `observability_matrix`, `observability_subspace`, `is_observable`, > > `series`, `parallel` (interconnection) and many more which can be useful > > for any Engineer attempting to solve a `control` problem. > > > The main aim would be to make the whole model symbolic. The package will > > use some of sympy's core classes like `Basic` so as to avoid rewriting code. > > > In the later part of the program, I'll also introduce some graphical > > analyses such as the Bode diagram, the Nyquist diagrams etc.. > > In the meantime, I'll take some inspiration from other CAS as much as > possible. > > I'm also ready to implement some other ideas which the community or my > potential mentor will suggest. > > Regards, > Naman > > > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sympy+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/CALkUZDniQkQkpnhDMivsRBwPSyFkCLgp4EYqZpuqhE%2BLAHwrew%40mail.gmail.com. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAHVvXxRnbKS%3DNpwmKA7JRtDO%3Du7d-kV50pzU5VXH34roA8m7Ww%40mail.gmail.com.
