On Thu, 2012-06-14 at 14:06 +0200, Guillaume Ayoub wrote:
> Le lundi 11 juin 2012 à 18:55 +0200, Patrick Ohly a écrit :
> […]
> > 
> > Radicale supports the former, but it has a bug (or missing feature,
> > depending on how you look at it): when asked to filter items in a REPORT
> > by data type, it returns items of the wrong type. Below is an example
> > (asked for VEVENT, reports VTODO).
> > 
> > In comparison, Apple Calendar Server does honor the filter as I expect.
> > 
> > Guillaume, what do you think? Is this a bug and can it be fixed?
> 
> It's a well known missing feature, reported here:
> http://redmine.kozea.fr/issues/53
> 
> Filters are really hard to handle, as they imply that the server can
> understand ical. By design, Radicale does not understand ical, it can
> only find begin/end couples, types and IDs.

I understand your design intention. However, it is somewhat dangerous:
even clients that work today may tomorrow start using a new, unsupported
feature, which may result in fatal (= data loss) issues.

In this particular case it would have been safer to reject all requests
which contain such a filter clause, because it was known that Radicale
doesn't implement that. It would have allowed SyncEvolution to detect
whether the server supports the features: try to use it and fall back to
reading everything if that fails.

> But handling basic filters, such as the one needed for SyncEvolution,
> should be possible. I can even try to add some code about this right
> now :).
> 
> I'll send you a mail as soon as something is pushed (or not).

Thanks. I've tested that commit, seems to work. It doesn't allow me to
remove the "download all data" part because users will not update
immediately, but it will be a bit more efficient.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.


_______________________________________________
SyncEvolution mailing list
SyncEvolution@syncevolution.org
http://lists.syncevolution.org/listinfo/syncevolution

Reply via email to