On 30/04/2012 13:39, Emmanuel Lécharny wrote: > Hi, Hi Emmauel, (moving to this thread in order to keep discussion separated from actual vote).
See my comments embedded. Regards. > Le 4/27/12 12:14 PM, Francesco Chicchiriccò a écrit : >> I've created a 1.0.0-RC1-incubating release, with the following >> artifacts up for a vote: >> >> SVN source tag (r1331322): >> https://svn.apache.org/repos/asf/incubator/syncope/tags/syncope-1.0.0-RC1-incubating/ >> >> >> Maven staging repo: >> https://repository.apache.org/content/repositories/orgapachesyncope-002/ >> >> Source release (checksums and signatures are available at the same >> location): >> https://repository.apache.org/content/repositories/orgapachesyncope-002/org/apache/syncope/syncope-root/1.0.0-RC1-incubating/syncope-root-1.0.0-RC1-incubating-source.tar.gz >> >> https://repository.apache.org/content/repositories/orgapachesyncope-002/org/apache/syncope/syncope-root/1.0.0-RC1-incubating/syncope-root-1.0.0-RC1-incubating-source.zip >> > > I have checked out and downloaded the sources, and built them (from > the repos, and from the tarball). > > After having (successfully) compiled them, the resulting jar files are > not equals (I did a cmp on them, and I found differences). Could you please detail which JAR files have you find different? I have downloaded tar.gz and .zip bundles + checked out the svn tag in three different directories, then launched mvn clean install from the three directories containing the root POM, finally compared these files, from each subdir: build-tools/target/syncope-build-tools-1.0.0-RC1-incubating-classes.jar console/target/syncope-console-classes.jar core/target/syncope-classes.jar client/target/syncope-client-1.0.0-RC1-incubating.jar build-tools/target/syncope-build-tools-1.0.0-RC1-incubating.war console/target/syncope-console.war core/target/syncope.war I've also found that in some cases the same file (i.e. syncope.war, for example) is different from the various directories, but also verified that this is happening for things like: * timestamps (generated pom.properties, for example) * resources filtered by Maven with properties depending on the source path (content.xml for bundles directory, or logback.xml for log directory) > I think the difference comes from a generated file > (core/target/cargo/configurations/tomcat7x/work/Catalina/localhost/syncope/org/apache/jsp/syncopeClientError_jsp.java) > which contains a header with a timestamp. I don't think so, this is a runtime file generated by the Tomcat instance started by cargo plugin as part of core integration tests and is not included in any published artifact. > I have ran mvn rat:check (and not mvn apache-rat:check, which does not > work)... Thanks for reporting: I've just fixed this ("mvn apache-rat:check" -> mvn rat:check) in release-process.xml > There are still a few files with a missing ASL 2.0 license : > > core/src/test/resources/spring.jsp > core/src/test/resources/exploredb.jsp > core/src/test/resources/db.jsp > core/src/main/webapp/version.jsp > core/src/main/webapp/syncopeClientError.jsp > core/src/main/webapp/dbExport.jsp > core/src/main/webapp/cacheStats.jsp > > JSP are part of the project, and you should also include the license > header in those files. Correct, I'll take care of this right away. > Sorry, guys :/ -- Francesco Chicchiriccò Apache Cocoon PMC and Apache Syncope PPMC Member http://people.apache.org/~ilgrosso/
