Hi Simone, (moving to this thread in order to keep discussion separated from actual vote).
See my comments embedded. Regards. On 30/04/2012 14:06, Simone Tripodi wrote: > -1 > > maven RAT plugin show unapproved licenses on sources: > > !????? > /private/tmp/syncope-1.0.0-RC1-incubating/core/src/main/resources/META-INF/services/org.identityconnectors.common.logging > !????? > /private/tmp/syncope-1.0.0-RC1-incubating/core/src/main/webapp/cacheStats.jsp > !????? > /private/tmp/syncope-1.0.0-RC1-incubating/core/src/main/webapp/dbExport.jsp > !????? > /private/tmp/syncope-1.0.0-RC1-incubating/core/src/main/webapp/syncopeClientError.jsp > !????? > /private/tmp/syncope-1.0.0-RC1-incubating/core/src/main/webapp/version.jsp > !????? > /private/tmp/syncope-1.0.0-RC1-incubating/core/src/test/resources/db.jsp > !????? > /private/tmp/syncope-1.0.0-RC1-incubating/core/src/test/resources/exploredb.jsp > !????? > /private/tmp/syncope-1.0.0-RC1-incubating/core/src/test/resources/spring.jsp > !????? > /private/tmp/syncope-1.0.0-RC1-incubating/core/src/test/resources/test.csv > > you can configure RAT in order to exclude the csv resource but JSPs > are sources that need to be released under the ASL2.0 license Ok, I'll do it immediately. > Small hint: plug rat plugin at release time so you can check before > releasing and have bad surprises once all the work has been done. I'll do this as well. > Moreover, zip/tarball contains useless subdirectories, even if not > blocking it would worth having it fixed since a new RC has to be > rolled out. Yep, since we'll have to go through the all process one more, there is no reason to don't include the fix for this. > Anyway, build works fine with a fresh repo, I tried with the command > below and this time didn't get dependencies resolution errors > > +--------+ > mvn -Dmaven.repo.local=/tmp/syncope-repo install > +--------+ -- Francesco Chicchiriccò Apache Cocoon PMC and Apache Syncope PPMC Member http://people.apache.org/~ilgrosso/
