> On 2009-05-02 03:39:05.191325, Paul Wise wrote: > > Few things to fix. I recon the next/previous second buttons might be useful.
I'll add a new patch later... > On 2009-05-02 03:39:05.191325, Paul Wise wrote: > > Screenshot: New navigation button in the lower left corner > > <http://patches.synfig.org> > > > > Hmm, looks a bit cluttered. Yes, I agree, hence my suggestion for a standalone button bar at the top of the canvas window. This would give us more space for more and bigger icons. We could, however, go for the current layout as a intermediate solution. > On 2009-05-02 03:39:05.191325, Paul Wise wrote: > > Screenshot: New navigation button in the lower left corner > > <http://patches.synfig.org> > > > > What about putting all the buttons on the same row, above the time > > sliders? Wouldn't this solution significantly shrink the horizontal canvas slider? Particularly if we add even more buttons? > On 2009-05-02 03:39:05.191325, Paul Wise wrote: > > synfig-studio/trunk/src/gtkmm/framedial.h, line 2 > > <http://patches.synfig.org/r/23/diff/1/?file=226#file226line2> > > > > wrong filename Fixed. > On 2009-05-02 03:39:05.191325, Paul Wise wrote: > > synfig-studio/trunk/src/gtkmm/framedial.h, line 5 > > <http://patches.synfig.org/r/23/diff/1/?file=226#file226line5> > > > > This should be $Id$ and the right svn properties set. Fixed. > On 2009-05-02 03:39:05.191325, Paul Wise wrote: > > synfig-studio/trunk/src/gtkmm/framedial.h, line 9 > > <http://patches.synfig.org/r/23/diff/1/?file=226#file226line9> > > > > This is a new file, shouldn't you put your copyright here instead of > > dooglus/darco/etc? Fixed. > On 2009-05-02 03:39:05.191325, Paul Wise wrote: > > synfig-studio/trunk/src/gtkmm/framedial.h, lines 69-80 > > <http://patches.synfig.org/r/23/diff/1/?file=226#file226line69> > > > > This is a header file, please put the code in the .cpp file. Moved. > On 2009-05-02 03:39:05.191325, Paul Wise wrote: > > synfig-studio/trunk/src/gtkmm/framedial.cpp, line 3 > > <http://patches.synfig.org/r/23/diff/1/?file=227#file227line3> > > > > same as above same as above > On 2009-05-02 03:39:05.191325, Paul Wise wrote: > > synfig-studio/trunk/src/gtkmm/framedial.cpp, line 5 > > <http://patches.synfig.org/r/23/diff/1/?file=227#file227line5> > > > > Same as above Same as above > On 2009-05-02 03:39:05.191325, Paul Wise wrote: > > synfig-studio/trunk/src/gtkmm/framedial.cpp, line 8 > > <http://patches.synfig.org/r/23/diff/1/?file=227#file227line8> > > > > same as above same as above > On 2009-05-02 03:39:05.191325, Paul Wise wrote: > > synfig-studio/trunk/src/gtkmm/framedial.cpp, line 32 > > <http://patches.synfig.org/r/23/diff/1/?file=227#file227line32> > > > > Probably need to uncomment this after moving the code into METHODS > > below. Fixed. > On 2009-05-02 03:39:05.191325, Paul Wise wrote: > > synfig-studio/trunk/src/gtkmm/zoomdial.h, line 97 > > <http://patches.synfig.org/r/23/diff/1/?file=229#file229line97> > > > > This belongs in the framedial.h header not here. I disagree. I think that we should not, in general, have these code insertion macro's. They were useful in C in some situations, but they're not needed anymore in C++ (inline's, reference parameters, templates, etc.). Since they quickly contaminate the CPP namespace, they are even worse in header files. So, to me, we either #undef them as soon as we no longer needed (the quick fix I did), of we follow your suggestion above and move the code to the .cpp file (which I would prefer) in a separate commit. > On 2009-05-02 03:39:05.191325, Paul Wise wrote: > > synfig-studio/trunk/src/gtkmm/framedial.h, line 3 > > <http://patches.synfig.org/r/23/diff/1/?file=226#file226line3> > > > > Please customise this Actually, very few files in the code base have this doxygen entry filled in. I know it is not a particular good reason, but it does set a bit of a precedent... :-) - Gerco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/23/#review53 ----------------------------------------------------------- On 2009-04-30 05:21:20.605360, Gerco Ballintijn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://patches.synfig.org/r/23/ > ----------------------------------------------------------- > > (Updated 2009-04-30 05:21:20.605360) > > > Review request for Synfig. > > > Summary > ------- > > Synfigstudio allows you in a canvas to go to the beginning, end, previous > frame, and next frame by using key bindings *only*. This patch adds the > necessary buttons to the canvas window. The patch does not add the previous > and next *second* buttons. These can however easily be added. > > Note: This patch is a work-in-progress. There are at least the following > points to consider: > * We might want to move (add) the play (and stop) buttons to the spot below > the navigation buttons, since there is room and they are conceptually related. > * The patch uses synfig-specific icons which prevents (make's it more > difficult?) changing them with skin changes. > * The icons used on the buttons are inconsistent with the buttons in the menu > (buttons synfigstudio is not consistent in other places either). > * We might want to add a proper menu bar and a proper button to the canvas > window, to be (more) consistent with other GUI application, but this would be > a (much) bigger change. > > > This addresses bug 2517389. > http://sf.net/support/tracker.php?aid=2517389 > > > Diffs > ----- > > synfig-studio/trunk/images/Makefile.am 2362 > synfig-studio/trunk/images/seek_begin.sif PRE-CREATION > synfig-studio/trunk/images/seek_end.sif PRE-CREATION > synfig-studio/trunk/images/seek_next_frame.sif PRE-CREATION > synfig-studio/trunk/images/seek_prev_frame.sif PRE-CREATION > synfig-studio/trunk/src/gtkmm/canvasview.cpp 2362 > synfig-studio/trunk/src/gtkmm/framedial.h PRE-CREATION > synfig-studio/trunk/src/gtkmm/framedial.cpp PRE-CREATION > synfig-studio/trunk/src/gtkmm/iconcontroller.cpp 2362 > synfig-studio/trunk/src/gtkmm/zoomdial.h 2362 > > Diff: http://patches.synfig.org/r/23/diff > > > Testing > ------- > > Compiles, runs, shows buttons, buttons work. > > > Screenshots > ----------- > > New navigation button in the lower left corner > http://patches.synfig.org/r/23/s/2/ > > > Thanks, > > Gerco > > ------------------------------------------------------------------------------ The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your production scanning environment may not be a perfect world - but thanks to Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700 Series Scanner you'll get full speed at 300 dpi even with all image processing features enabled. http://p.sf.net/sfu/kodak-com _______________________________________________ Synfig-devl mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/synfig-devl
