----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/23/#review76 -----------------------------------------------------------
Ship it! Although it can be rearranged later in other place it is a good start to make a more friendly main window. I approve the patch. - Carlos On 2009-05-08 05:44:48.124746, Gerco Ballintijn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://patches.synfig.org/r/23/ > ----------------------------------------------------------- > > (Updated 2009-05-08 05:44:48.124746) > > > Review request for Synfig. > > > Summary > ------- > > Synfigstudio allows you in a canvas to go to the beginning, end, previous > frame, and next frame by using key bindings *only*. This patch adds the > necessary buttons to the canvas window. The patch does not add the previous > and next *second* buttons. These can however easily be added. > > Note: This patch is a work-in-progress. There are at least the following > points to consider: > * We might want to move (add) the play (and stop) buttons to the spot below > the navigation buttons, since there is room and they are conceptually related. > * The patch uses synfig-specific icons which prevents (make's it more > difficult?) changing them with skin changes. > * The icons used on the buttons are inconsistent with the buttons in the menu > (buttons synfigstudio is not consistent in other places either). > * We might want to add a proper menu bar and a proper button to the canvas > window, to be (more) consistent with other GUI application, but this would be > a (much) bigger change. > > > This addresses bug 2517389. > http://sf.net/support/tracker.php?aid=2517389 > > > Diffs > ----- > > synfig-studio/trunk/images/Makefile.am 2375 > synfig-studio/trunk/images/seek_begin.sif PRE-CREATION > synfig-studio/trunk/images/seek_end.sif PRE-CREATION > synfig-studio/trunk/images/seek_next_frame.sif PRE-CREATION > synfig-studio/trunk/images/seek_prev_frame.sif PRE-CREATION > synfig-studio/trunk/src/gtkmm/Makefile.am 2375 > synfig-studio/trunk/src/gtkmm/canvasview.cpp 2375 > synfig-studio/trunk/src/gtkmm/framedial.h PRE-CREATION > synfig-studio/trunk/src/gtkmm/framedial.cpp PRE-CREATION > synfig-studio/trunk/src/gtkmm/iconcontroller.cpp 2375 > synfig-studio/trunk/src/gtkmm/zoomdial.h 2375 > > Diff: http://patches.synfig.org/r/23/diff > > > Testing > ------- > > Compiles, runs, shows buttons, buttons work. > > > Screenshots > ----------- > > New navigation button in the lower left corner > http://patches.synfig.org/r/23/s/2/ > > > Thanks, > > Gerco > > ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Synfig-devl mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/synfig-devl
