On 22/03/2016, Frank Villaro-Dixon <fr...@villaro-dixon.eu> wrote: > On 16-03-22 10:23:51, Nicolás Alvarez, wrote 1.2K characters saying: >> >>> El 22 mar 2016, a las 10:10, Frank Villaro-Dixon <fr...@villaro-dixon.eu> >>> escribió: >>> >>> # First goal: >>> First goal is quite simple. The idea is to work only on relations which >>> have a natural=water . Then, it will: >>> * Delete natural=water from all the ways if they are NOT closed or >>> ring 0. >> >>What if there is a way legitimately with natural=water that isn't closed >> because of an error? The correct fix is to close it, not to remove the >> tag. This cannot be done automatically. >> > It doesn't matter because this way will also be referenced by a relation > which has the natural=water tag. Thus, it can be removed from the way.
If the way being closed or not doesn't matter, then it shouldn't be part of your criterias ? I see this as a red flag indicating you didn't think long enough about the problem, and that doesn't bode well for an automated world-wide edit. You're conflating two different problems: 1) Some multipolygon relations have improper geometry, such as non-closed rings. 2) Some tags are "needlessly" repeated between the relation and its members. Neither of those problems are specific to water features. The first problem has many QA tools to point it out, for example OSMI[1]. Maybe some of them can be fixed automatically, but I'd much rather go through them manually[2] because some cases are strange, and often when one MP is broken there's lots of other bugs in the same area by the same user that deserve a fix. The second problem actually has the community a bit divided (last I heard of it), as some people *want* to have the actual ways tagged (usually for ease of consumption, but also for historical reasons). I usually delete the superfluous tag when I happen to be editing the object, but I wouldn't dare do this automatically on a global scale. And as long as those duplicate tags aren't contradicting each other, they are harmless. [1]:http://tools.geofabrik.de/osmi/?view=multipolygon [2]:http://wiki.openstreetmap.org/wiki/Quality_Assurance_Tools_script _______________________________________________ talk mailing list talk@openstreetmap.org https://lists.openstreetmap.org/listinfo/talk
