On Sun, Feb 07, 2010 at 10:10:31AM +0000, Mindaugas Rasiukevicius wrote: > > The copy involves 18 files from sys/ufs/ufs (out of 21; the ones > > excluded are quota.h and unsurprisingly ufs_wapbl.[ch]) which contain > > 9067 lines of code. That gives the following statistics: > > > > 14988 size of lfs currently > > + 9067 size of copypasted ufs > > 24055 size of resulting uncompilable lfs > > - 401 result of making it compilable > > 23654 size of new lfs > > How would this affect UFS side? For example, any potential code reduction > and/or simplification?
Yes. ufs_readwrite.c will become much less gross, for example. There used to be assorted LFS-only code in the ufs sources; ad@ removed the ifdefs some time ago but they could be resurrected and then used to purge the relevant code. I don't know how much code that is. As for deeper simplifications, I don't know without digging around a lot more than I have (particularly in the ext2fs code), but there should be some. > > Anyway, I have done this much and it's ready to go. I will be > > committing it tonight, I think, unless there are sudden howls of > > protest. > > This involves significant changes, therefore enough time should be left > for mailing list readers (~1 week at least, before committing anything). It was discussed months ago. This is a reminder/heads-up. -- David A. Holland dholl...@netbsd.org