On Tue, 10 Aug 2010 19:11:56 +0200, Matthias Drochner <m.droch...@fz-juelich.de> wrote: > jeanyves.mig...@free.fr said: >> But the NULL deref fixes will go in eventually, and I will probably >> ask for a pull up too ;) > > But then... > > algo = esp_algorithm_lookup(sav->alg_enc); > - if (!algo) { > + if (algo == NULL) { > ipseclog((LOG_ERR, > - "esp_cbc_mature %s: unsupported algorithm.\n", > algo->name)); > + "esp_cbc_mature: NULL is not a valid algorithm.\n")); > return 1; > > The new error message if not helpful. How about printing alg_enc > instead which is in a well-defined namespace.
Sure. I invite others to comment on these small patches... -- Jean-Yves Migeon jeanyves.mig...@free.fr