> On Wed, Aug 11, 2010 at 11:49:10PM +0200, Jean-Yves Migeon wrote: > [..] > > > I will commit the attached patch on Saturday, unless someone objects. > > > [..] > > > Index: external/bsd/drm/dist/shared-core/radeon_cs.c > > =================================================================== > > RCS file: /cvsroot/src/sys/external/bsd/drm/dist/shared-core/radeon_cs.c,v > > retrieving revision 1.1 > > diff -u -p -r1.1 radeon_cs.c > > --- external/bsd/drm/dist/shared-core/radeon_cs.c 24 May 2010 01:39:06 > > -0000 1.1 > > +++ external/bsd/drm/dist/shared-core/radeon_cs.c 11 Aug 2010 19:54:26 > > -0000 > > @@ -150,7 +150,6 @@ int radeon_cs_ioctl(struct drm_device *d > > > > if (dev_priv == NULL) { > > DRM_ERROR("called with no initialization\n"); > > - DRM_SPINUNLOCK(&dev_priv->cs.cs_mutex); > > return -EINVAL; > > } > > if (!cs->num_chunks) { > > Hmm, you didn't mention why you are doing that in your initial mail.
indeed, this seems entirely wrong. do not commit this part. .mrg.