On Sun, Jan 8, 2012 at 2:13 PM, David Laight <da...@l8s.co.uk> wrote: > On Sat, Jan 07, 2012 at 06:24:53PM +0400, Evgeniy Ivanov wrote: >> Hi, >> >> Here're updated patches. Tested on sparc (build only). Gnats ID is lib/45796. > > Looks like a lot of replicated code from elsewhere in libsa. > You really ought to manage to factor out a lot of the common bits. > libsa is all about code size, performance is secondary.
I agree. But as we talked with Izumi earlier, it's similar to ext2fs and ufs code relations. Refactoring will require modifying all these three fs implementations and I'm not in position to work on this now. -- Evgeniy
