On Sun, Jan 8, 2012 at 7:01 PM, Izumi Tsutsui <tsut...@ceres.dti.ne.jp> wrote: >> > Here're updated patches. Tested on sparc (build only). Gnats ID is >> > lib/45796. >> >> Looks like a lot of replicated code from elsewhere in libsa. >> You really ought to manage to factor out a lot of the common bits. > > Can you mention more specific sources/functions? > >> libsa is all about code size, performance is secondary. > > libsa.a library might become bigger, but unused stuff won't linked > into the target standalone programs unless MINIXv3FS is explicitly > specified in conf.c etc. > > > Current ufs.c is a factored out source (for ffsv1/ffsv2/lfsv1/lfsv2), > but compiled binaries are not unified anyway. > > (sys/arch/i386/stand/lib/biosdisk.c should have #ifdef SUPPORT_MINIXFS3 > though)
Hm, I think it's not bad to see real partitioning even without MINIXFS3 support. If you disagree I can add that ifdef though. -- Evgeniy
