On 13-11-05 10:12 AM, Adam Thompson wrote:
I can do doc changes, but I think you really, *really* don't want me
writing much C code... I can perhaps do some of the initial, trivial,
legwork, at best. Now, if bgpd(8) were written in Bourne/Korn shell,
I'd be the guy to do this!
I recall now that I've never used yacc... Here's what I *can*
contribute, which is not much.
I wonder about including it as a global, per-neighbour, and per-match,
but it seems to be consistent with what's already implemented.
It would be acceptable to have it only as an attribute;
It would be more reasonable to have it as a global config item and an
attribute;
And at that point it may as well be settable on a neighbour basis, too.
--
-Adam Thompson
athom...@athompso.net
Index: bgpd.conf.5
===================================================================
RCS file: /cvs/src/usr.sbin/bgpd/bgpd.conf.5,v
retrieving revision 1.129
diff -u -p -r1.129 bgpd.conf.5
--- bgpd.conf.5 19 Oct 2013 15:04:25 -0000 1.129
+++ bgpd.conf.5 5 Nov 2013 17:45:23 -0000
@@ -206,6 +206,14 @@ dump all out "/tmp/all-out-%H%M" 300
dump updates out "/tmp/updates-out-%H%M" 300
.Ed
.Pp
+.It Ic fib-priority Ar priority
+If set, override the route priority value used to insert BGP routes
+into the kernel routing table. The default is
+.Ic RTP_BGP
+as defined in /usr/include/sys/net/route.h.
+.Pp
+Currently not implemented.
+.Pp
.It Xo
.Ic fib-update
.Pq Ic yes Ns | Ns Ic no
@@ -459,6 +467,14 @@ should be set to
.Ar rt
for best compatibility with other implementations.
.Pp
+.It Ic fib-priority Ar priority
+If set, override the route priority value used to insert BGP routes
+into the kernel routing table. The default is
+.Ic RTP_BGP
+as defined in /usr/include/sys/net/route.h.
+.Pp
+Currently not implemented.
+.Pp
.It Xo
.Ic fib-update
.Pq Ic yes Ns | Ns Ic no
@@ -757,6 +773,14 @@ The default value for IBGP peers is
otherwise the default is
.Ic yes .
.Pp
+.It Ic fib-priority Ar priority
+If set, override the route priority value used to insert BGP routes
+into the kernel routing table. The default is
+.Ic RTP_BGP
+as defined in /usr/include/sys/net/route.h.
+.Pp
+Currently not implemented.
+.Pp
.It Ic holdtime Ar seconds
Set the holdtime in seconds.
Inherited from the global configuration if not given.
@@ -1365,6 +1389,14 @@ bdc BGP Data Collection
.Pp
Not all type and subtype value pairs are allowed by IANA and the parser
will ensure that no invalid combination is created.
+.Pp
+.It Ic fib-priority Ar priority
+If set, override the route priority value used to insert BGP routes
+into the kernel routing table. The default is
+.Ic RTP_BGP
+as defined in /usr/include/sys/net/route.h.
+.Pp
+Currently not implemented.
.Pp
.It Ic localpref Ar number
Set the
Index: parse.y
===================================================================
RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v
retrieving revision 1.268
diff -u -p -r1.268 parse.y
--- parse.y 19 Oct 2013 15:04:25 -0000 1.268
+++ parse.y 5 Nov 2013 17:45:23 -0000
@@ -171,6 +171,7 @@ typedef struct {
%}
%token AS ROUTERID HOLDTIME YMIN LISTEN ON FIBUPDATE RTABLE
+%token FIBPRIORITY
%token RDOMAIN RD EXPORTTRGT IMPORTTRGT
%token RDE RIB EVALUATE IGNORE COMPARE
%token GROUP NEIGHBOR NETWORK
@@ -2139,6 +2140,7 @@ lookup(char *s)
{ "evaluate", EVALUATE},
{ "export-target", EXPORTTRGT},
{ "ext-community", EXTCOMMUNITY},
+ { "fib-priority", FIBPRIORITY},
{ "fib-update", FIBUPDATE},
{ "from", FROM},
{ "group", GROUP},
