Am 08/08/15 um 15:06 schrieb Alexey Suslikov:
On Sat, Aug 8, 2015 at 2:21 PM, Christian Schulte <c...@schulte.it> wrote:
Am 08/07/15 um 23:46 schrieb Alexey Suslikov:
Christian Schulte <cs <at> schulte.it> writes:
Now, I believe that this effort is too much for my spare time.
Then why not release that scanner? That effort could be shared. What's
so secret about it? You have been asked several times already.
Start sharing right now. Brainy OpenBSD page contains info about
lot of bugs already found. There is no secret to start writing
diffs and pushing them.
I was thinking about automating that process. Scan-before-commit, for
example. Need not be that particular scanner. Some pre-commit analysis
beyond what the compiler can warn about. How can I be sure the issues found
by that scanner are not issues with the scanner itself?
Looks like you haven't read carefully. Quote:
"Developing, improving and maintaining Brainy takes time and energy, as
well as investigating and packaging the bugs and vulnerabilities it
finds".
You already have bugs found. Next step in the process is to write diffs.
Are you referring to this?
<http://m00nbsd.net/e5ab5f6e59d6a0feb7d1a518acc8233d.html>
_11/ MEMORY LEAK: sys/dev/ic/ti.c rev1.15
Leak of 'm_new' with MGETHDR() at l.648.
_14/ UNINITIALIZED VARIABLE: sys/arch/hppa64/dev/apic.c rev1.8
At l.176, 'cnt' is not initialized.
Index: sys/dev/ic/ti.c
===================================================================
RCS file: /cvs/src/sys/dev/ic/ti.c,v
retrieving revision 1.12
diff -u -r1.12 ti.c
--- sys/dev/ic/ti.c 22 Dec 2014 02:28:51 -0000 1.12
+++ sys/dev/ic/ti.c 8 Aug 2015 15:00:55 -0000
@@ -655,6 +655,7 @@
if (bus_dmamap_load_mbuf(sc->sc_dmatag, dmamap, m_new,
BUS_DMA_NOWAIT)) {
+ m_freem(m_new);
m_freem(m);
return (ENOBUFS);
}
