Stuart Henderson <s...@spacehopper.org> wrote: > On 2018/09/04 12:07, Solene Rapenne wrote: > > Naoki Fukaumi <fuka...@soum.co.jp> wrote: > > > hi tech@, > > > > > > new cpu state, CP_SPIN, was added, > > > https://marc.info/?l=openbsd-cvs&m=152630109526317&w=2 > > > > > > but there is no column for it in the header of iostat, > > > > > > $ iostat > > > tty sd0 cpu > > > tin tout KB/t t/s MB/s us ni sy in id > > > 0 1 11.47 3 0.04 0 0 0 0 0100 > > > > > > this patch adds "sp" for CP_SPIN. > > > > > > -- > > > FUKAUMI Naoki > > > > > > Index: usr.sbin/iostat/iostat.c > > > =================================================================== > > > RCS file: /cvs/src/usr.sbin/iostat/iostat.c,v > > > retrieving revision 1.40 > > > diff -u -p -u -p -r1.40 iostat.c > > > --- usr.sbin/iostat/iostat.c 10 Feb 2018 19:49:50 -0000 1.40 > > > +++ usr.sbin/iostat/iostat.c 4 Sep 2018 04:19:14 -0000 > > > @@ -229,7 +229,7 @@ header(void) > > > printf(" %16.16s ", cur.dk_name[i]); > > > > > > if (ISSET(todo, SHOW_CPU)) > > > - printf(" cpu"); > > > + printf(" cpu"); > > > printf("\n"); > > > > > > /* Sub-Headers. */ > > > @@ -254,7 +254,7 @@ header(void) > > > printf(" KB xfr time "); > > > > > > if (ISSET(todo, SHOW_CPU)) > > > - printf(" us ni sy in id"); > > > + printf(" us ni sy sp in id"); > > > printf("\n"); > > > } > > > > > > > ok solene@ for this, but the man page should be updated too, it contains the > > list of columns displayed. > > > > Is iostat(8) something where people are likely to parse output? > > (I first thought of sysutils/munin, iostat parsing is not enabled > there, but there might be others).
About munin I'm trying to get a diff accepted upstream to fix cpu plugin and talk about this with kirby@. The cpu plugin uses sysctl kern.cp_time. While it's not related, I prefer to announce it here so people don't waste time fixing it again by looking at the thread :)
