On 31/12/18(Mon) 16:58, Alexandre Ratchov wrote: > Hi, > > Here's a new driver for both USB audio class (UAC) v1.0 and v2.0 > devices, it would replace the current one. It focuses on reliability > and proper synchronization, including in low-latency configurations.
Some comments about the code. I believe this should go in now so we can tackle the remaining issue in tree, so ok mpi@ - Please put the UE_* macro in dev/usb/usb.h (not sys/usb.h) ;o) - You could get rid of UAUDIO_NRATES and use nitems() instead - What does UAUDIO_USE_FRAC mean? - Some values read from descriptors are passed to malloc(9) w/o being checked. Take the example of `count' in uaudio_req_ranges(). What's the maximum size for `count' and `req_size'? What's the maximum value for `nframes_max'? - You don't need to call usbd_abort_pipe(9) before calling usbd_close_pipe(9), it does it for you. - What about using %s __func__ in DPRINTF() instead of function names to help search through your code? ;o)
