On Mon, Oct 09, 2023 at 10:07:36PM +0200, Mark Kettenis wrote: > > Date: Mon, 09 Oct 2023 20:31:04 +0200 > > From: Mark Kettenis <mark.kette...@xs4all.nl> > > > > > Date: Mon, 9 Oct 2023 06:09:57 +0200 > > > From: "Peter J. Philipp" <p...@delphinusdns.org> > > > > > > On Sun, Oct 08, 2023 at 07:42:54PM +0200, Mark Kettenis wrote: > > > > Hector Martin has added support for the BCM4388 that is found on the > > > > last generation of Apple Macs. Based on his commits I've managed to > > > > get it working on my M2 Pro mini. I still have to clean up some of > > > > that stuff, but here is a forst batch of two diffs. > > > > > > > > The changes to dev/ic/bwfm.c correspond to: > > > > > > > > https://github.com/AsahiLinux/linux/commit/81e3cc7bec8b9d9c436f63662d8fcfda4f637807 > > > > > > > > The changes to dev/pci/if_bwfm_pci.c corrspond to: > > > > > > > > https://github.com/AsahiLinux/linux/commit/8190add8671fc49c12d04b5ac8fced70f835e69f > > > > > > > > Both changes seem to be a good idea and potentially affect other chips > > > > as well. So if you have a machine with bwfm(4), please test. > > > > > > > > ok? > > > > > > Hi, > > > > > > I have an early 2015 MacBookPro that doesn't like this. It fails to load > > > the firmware even after I deleted it with fw_update -d and readded it. > > > > > > What results is probably an interrupt storm as the system becomes > > > unresponsive. Sorry I can't give very much more details. > > > > Thanks, I actually have one of these myself. So I'm going to > > investigate (and probably drop one of the diffs). > > I don't see any problems on my machine. Firmware loads and WiFi works > just fine on my MacBookPro12,1. >
Hmm odd. I'll have to check again. Thanks Mark! -peter -- Over thirty years experience on Unix-like Operating Systems starting with QNX.
