On 22/10/09 01:03, Travis Basevi wrote: [snip stuff]
> I suspect, without easily being able to test it, that the only issue is > that TT is acting differently between perl 5.8 and 5.10, and the version > of TT is irrelevant. Doesn't this make it a TT issue? You missed the bit where I said: > OK, so I *DON'T* get this with TT 2.19 on perl 5.8.8 on etch so it > doesn't look like it's directly a problem with TT but I definitely do > get it with the perl one liner as above. So on the same version of etch, with a newer TT, I don't get the warning you also don't get on etch with the older TT. With the same version of TT on a newer version of Debian we both see the error. Just for completeness, I've installed TT 2.14 on a vanilla lenny machine and lo, I get the warning. Therefore I conclude that the problem is not with TT itself but elsewhere in the module chain. So, it's not a bug in TT per se, i.e. it's not a regression, it's always been this way but it is a change in behaviour caused by a change *elsewhere*. The subsequent question is whether TT should change to suppress the warnings. The perl warning seems reasonable to me. It's a code smell to be trying a numeric comparison on something that's not numeric. The Right Thing To Do[tm] is to fix your code so that empty strings are turned into zeros or something else that makes sense in your application BEFORE you hand it off to the template for display. If you really think that TT should be changed, you need to track down the module that's changed and then file a change request in CPAN RT with all the necessary details to allow Andy to understand the problem, exactly what's caused it and what the required change should be. Personally, I've been bitten more than once by the silent swallowing of warnings about undefined variables so I'm not sure I'd want more silent swallowing to be going on, at least not without explicitly turning it on. Rgds, Simon. _______________________________________________ templates mailing list templates@template-toolkit.org http://mail.template-toolkit.org/mailman/listinfo/templates
