Joe Orton wrote:
On Mon, Aug 09, 2004 at 02:33:34PM -0700, Stas Bekman wrote:
I have tested with a checkout from Aug 1 and t/modules/access fails just the same, so it's definitely unrelated to my changes over the weekend. I
I can't confirm that - the break occurs from the change between 18:00 and 19:00 UTC on 6th August
Doh! I wonder why my checkout from Aug 1st was failing just as well :( May be it was a wrong checkout.
which would seem to correspond to this comment:
"split the config object creation in 2 parts - first not requiring the knowledge of httpd location, the second requiring one"
and the following change:
- $self->configure_apxs; - $self->configure_httpd; - $self->inherit_config; #see TestConfigParse.pm - $self->configure_httpd_eapi; #must come after inherit_config - $self->default_module(cgi => [qw(mod_cgi mod_cgid)]); $self->default_module(thread => [qw(worker threaded)]); $self->default_module(ssl => [qw(mod_ssl)]);
which occurs in TestConfig::new(), which is now designated as
# setup httpd-independent components # for httpd-specific call $self->httpd_config()
so I guess that assumption is wrong - default_module needs a complete httpd setup to apply module naming magic, at least in cases where the module is compiled in statically.
Aha! Excellent, Geoff! Does it solve the problem by moving those default_module calls after getting httpd config?
Index: lib/Apache/TestConfig.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.pm,v
retrieving revision 1.235
diff -u -r1.235 TestConfig.pm
--- lib/Apache/TestConfig.pm 9 Aug 2004 06:19:15 -0000 1.235
+++ lib/Apache/TestConfig.pm 10 Aug 2004 16:55:29 -0000
@@ -313,13 +313,6 @@
$vars->{proxyssl_url} ||= '';
$vars->{defines} ||= '';
- $self->default_module(cgi => [qw(mod_cgi mod_cgid)]);
- $self->default_module(thread => [qw(worker threaded)]);
- $self->default_module(ssl => [qw(mod_ssl)]);
- $self->default_module(access => [qw(mod_access mod_authz_host)]);
- $self->default_module(auth => [qw(mod_auth mod_auth_basic)]);
- $self->default_module(php => [qw(mod_php4 mod_php5)]);
-
$self->{hostport} = $self->hostport;
$self->{server} = $self->new_test_server;@@ -357,6 +350,14 @@
unless (custom_config_exists()) {
$self->custom_config_save($self->{vars});
}
+
+ $self->default_module(cgi => [qw(mod_cgi mod_cgid)]);
+ $self->default_module(thread => [qw(worker threaded)]);
+ $self->default_module(ssl => [qw(mod_ssl)]);
+ $self->default_module(access => [qw(mod_access mod_authz_host)]);
+ $self->default_module(auth => [qw(mod_auth mod_auth_basic)]);
+ $self->default_module(php => [qw(mod_php4 mod_php5)]);
+ $self->inherit_config; #see TestConfigParse.pm
$self->configure_httpd_eapi; #must come after inherit_config-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
