Joe Orton wrote:
> On Wed, Aug 11, 2004 at 01:17:04AM -0700, Stas Bekman wrote:
>
>>I'd rather see it moved two statements (it still works, doesn't it?) so
>>the eapi comes right after inherit_config. Otherwise, yes, please commit it.
>
>
> Yes, great, done.
>
>
>>so are we all clean now? Any other problems?
>
>
> No failures with HEAD again now - thanks a lot.
since I don't have ssl compiled in I still have one issue:
t/TEST -clean
Use of uninitialized value in hash element at
/src/httpd-test-pristine/perl-framework/Apache-Test/lib/Apache/TestConfig.pm
line 1340.
the attached patch fixes it and explains what the issue is.
--Geoff
? ssl.patch
Index: lib/Apache/TestConfig.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.pm,v
retrieving revision 1.236
diff -u -r1.236 TestConfig.pm
--- lib/Apache/TestConfig.pm 11 Aug 2004 08:42:36 -0000 1.236
+++ lib/Apache/TestConfig.pm 11 Aug 2004 12:44:57 -0000
@@ -1013,6 +1013,12 @@
my $self = shift;
$self->{clean_level} = shift || 2; #2 == really clean, 1 == reconfigure
+ # we can't clean the server until it is fully configured
+ # for instance, at this point we haven't called default_module yet,
+ # which means that we don't know which ssl module we're even looking
+ # for in sslca_clean/sslca_can
+ $self->httpd_config;
+
$self->new_test_server->clean;
$self->cmodules_clean;
$self->sslca_clean;
