In which case we need to remove the custom patterns we have added so far?
hmm, did we actually add any, or just make the regex a bit more loose? I can't recall.
can you see how Apache-PREFORK-AdvancedExtranetServer/2.0.52 matches 1?
That's because our code is completely broken, since this is bogus:
# Apache-AdvancedExtranetServer/1.3.29 (Mandrake Linux/1mdk)
($self->{rev}) ||= $self->{version} =~ m|^Apache.*?/(\d)\.|;# IBM_HTTP_SERVER/1.3.19 Apache/1.3.20 (Unix)
($self->{rev}) ||= $self->{version} =~ m|^.*?Apache.*?/(\d)\.|;it always matches 1. It should be:
# Apache-AdvancedExtranetServer/1.3.29 (Mandrake Linux/1mdk)
($self->{rev}) ||= ($self->{version} =~ m|^Apache.*?/(\d)\.|);# IBM_HTTP_SERVER/1.3.19 Apache/1.3.20 (Unix)
($self->{rev}) ||= ($self->{version} =~ m|^.*?Apache.*?/(\d)\.|);we have noticed that bug, since those patterns were written when testing 1.3 and of course it has matched 1 :)
+1, but the last time we added a new pattern when somebody brought an argument, that users weren't able to run A-T because of this failure and waiting for the vendor to fix this was not an option. Moreover if users download A-T from CPAN and not a binary package from the vendor, they will have this problem and they will come to complain here.
So may be my suggestion of just matching the "/x.y.zz" part is worth a try?
sure, if you want to try :) another option is to create some kind of flag, env variable, or whatnot that skips the check and forces a version. this would essentially allow the user to say "yes, I know what I'm doing, use APACHE2."
Let's try first with a relaxed /x.y.zz", before we add yet another env var.
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
