[ 
https://issues.apache.org/jira/browse/THRIFT-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904019#action_12904019
 ] 

David Reiss commented on THRIFT-876:
------------------------------------

> I think if this is something that at least a couple people want to use, we 
> should put it in the project.
I actually disagree with that.  Every feature we add to Thrift makes it less 
approachable for everyone who isn't using it.  Even if "a couple people" it, we 
need to consider the cost for everyone else.  Otherwise, Thrift will just 
become a massive unnavigable pile of half-implemented  special-purpose 
features.  (Mark Slee wrote a great email about this a few months ago, but I 
unfortunately can't find it now.)

That said, I think it is also possible bundle "add-on"-type features like this 
in the main codebase without considering them core components of Thrift.  It 
has the benefit of allowing internal API changes to hit both core and non-core 
components at the same time, and obviously simplifies dependencies.

If we're going to go ahead with that, I'd feel more comfortable if we all 
informally agree to think of this as an add-on component, rather than a 
defining feature of Thrift.  In fact, there are a lot of components already in 
the source tree that I think we should think of like that.  Examples include 
the zlib transport in C++, the disklog transport in Erlang, and (IMO) all of 
the HTTP clients and servers.

> Add SASL support
> ----------------
>
>                 Key: THRIFT-876
>                 URL: https://issues.apache.org/jira/browse/THRIFT-876
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Java - Library
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: thrift-876.txt, thrift-876.txt.2
>
>
> It'd be nice if there were some way of securing Thrift communication in a 
> pluggable fashion. SASL is the implementation chosen by Hadoop for this. 
> Seems like a good option for Thrift, too.
> I'll start with a Java implementation, then move on to support the other 
> language bindings.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to