[
https://issues.apache.org/jira/browse/THRIFT-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904271#action_12904271
]
Bryan Duxbury commented on THRIFT-876:
--------------------------------------
Just so I can get a sense of what you're trying to give here, should this be
like an encrypted version of the framed transport? Where should people be
plugging this in? Right above their socket, or as the last TTransport before
the client?
Some comments:
* The rest of Thrift uses 2-space indentation, and you have 4-space
* Regards use of TFramedTransport.encodeFrameSize: if we're going to use this
same code in a variety of places, not just from within TFramedTransport and its
pseudo-descendant TFastFramedTransport, we should move it out into a separate
utility class
* Can you reuse the same empty byte[] in TSaslClientTransport.open()? Does it
actually do anything?
* TSaslClientTransport doesn't protect itself from being open()ed twice. Not
sure if this is important, but might be a good idea to mimic other transports.
* In TSaslTransport.postOpen(), there's no reason to instantiate your
TMemoryInputTransport with a new zero-length byte[]. Clearly you're going to
reset it with one of an actual size later, so don't waste the allocation.
* You should reuse a single 4-byte buffer in TSaslTransport for encoding and
decoding the frame size.
* You don't need to close your TMemoryInputTransports, since they're memory.
> Add SASL support
> ----------------
>
> Key: THRIFT-876
> URL: https://issues.apache.org/jira/browse/THRIFT-876
> Project: Thrift
> Issue Type: New Feature
> Components: Java - Library
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Attachments: thrift-876.txt, thrift-876.txt.2
>
>
> It'd be nice if there were some way of securing Thrift communication in a
> pluggable fashion. SASL is the implementation chosen by Hadoop for this.
> Seems like a good option for Thrift, too.
> I'll start with a Java implementation, then move on to support the other
> language bindings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
