[ 
https://issues.apache.org/jira/browse/THRIFT-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904815#action_12904815
 ] 

Aaron T. Myers commented on THRIFT-876:
---------------------------------------

bq. If you just throw a framed transport on top, the data will be buffered 
twice on the read side, which seems unnecessary.

This is certainly true, and undesirable.

I think the only thing that would need to change in the protocol specification 
to support buffering writes would be to also require a length prefix even in 
the event a QOP is not negotiated/used. I was trying to limit the scope of this 
specification to only the features strictly required to implement SASL, but 
this seems like a fine addition to support potentially dramatically improved 
performance.

I'll go ahead and make that change, as well as the change regarding extra data 
with the COMPLETE message, and post an updated spec.

If we're cool with it, I'm going to call this protocol spec complete and rework 
the Java implementation to implement this new spec.

> Add SASL support
> ----------------
>
>                 Key: THRIFT-876
>                 URL: https://issues.apache.org/jira/browse/THRIFT-876
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Java - Library
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: thrift-876.txt, thrift-876.txt.2, thrift-876.txt.3, 
> thrift-sasl-spec.txt
>
>
> It'd be nice if there were some way of securing Thrift communication in a 
> pluggable fashion. SASL is the implementation chosen by Hadoop for this. 
> Seems like a good option for Thrift, too.
> I'll start with a Java implementation, then move on to support the other 
> language bindings.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to