[
https://issues.apache.org/jira/browse/THRIFT-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906597#action_12906597
]
Todd Lipcon commented on THRIFT-876:
------------------------------------
Took a quick skim through the new transport factory class. One issue - the new
static maps should be wrapped with Collections.synchronizedMap(...) since it's
an unsynchronized data structure.
I think it's OK, though, that the containsKey() and .put() are unsynchronized,
since we assume that concurrent callers of getTransport() will always be
passing different base transports.
Another nit: the empty @param entries in the JavaDoc just take up space and
don't say anything.
One last thought: rather than making TSaslServerDefinition a private class and
taking the 5 parameters everywhere else, would it make a cleaner API to make it
public and force users to pass one into TSaslClientTransport,
TSaslServerTransport, addServerDefinition, etc. Feel free to disagree :)
> Add SASL support
> ----------------
>
> Key: THRIFT-876
> URL: https://issues.apache.org/jira/browse/THRIFT-876
> Project: Thrift
> Issue Type: New Feature
> Components: Java - Library
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Attachments: thrift-876.txt, thrift-876.txt.2, thrift-876.txt.3,
> thrift-876.txt.5, thrift-876.txt.6, thrift-sasl-spec.txt, thrift-sasl-spec.txt
>
>
> It'd be nice if there were some way of securing Thrift communication in a
> pluggable fashion. SASL is the implementation chosen by Hadoop for this.
> Seems like a good option for Thrift, too.
> I'll start with a Java implementation, then move on to support the other
> language bindings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
