[
https://issues.apache.org/jira/browse/THRIFT-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anthony Molinaro updated THRIFT-698:
------------------------------------
Attachment: erl-app.patch
This patch does a little bit more than what was required, but I was sort of
annoyed at the whole setup.
So what this patch does is totally revamps the makefiles for erlang. I got rid
of the whole build directory, pulled out the bits that were actually being used
and put those into a Makefile.am in the lib/erl/src directory. This allows me
to substitute in the correct version to the .app file. I think having the
correct version in the .app file will be important moving forward.
I also removed the {mod, {thrift_app, []}} from the .app.src file. This means
you can actually application:start (thrift) if you want (it doesn't do
anything, just loads and lists it in started applications.
I also removed the appup file since it is not useful at the moment anyway and
it seemed unnecessary.
And actually, what is the policy for including third party build scripts? I'd
love to drop
http://code.google.com/p/fwtemplates/downloads/detail?name=fwte-makeappfilev4
into place to just automagically generate the .app file from the source. It's
BSD license?
Anyway, unless anyone objects to my major refactoring of the make setup for
erlang, I'd like to commit this.
> Generated module list should contain atoms, not strings
> -------------------------------------------------------
>
> Key: THRIFT-698
> URL: https://issues.apache.org/jira/browse/THRIFT-698
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
> Reporter: Roberto Aloi
> Assignee: Anthony Molinaro
> Attachments: erl-app.patch
>
>
> The generated list of modules in the .app file should contain atoms, not
> lists. Please refer to the official Erlang documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
