Hallo, I am of the opinion that in the case of centring, the width of the story must always be a percentage (e.g. 60%). The sidebar must have a minimum width. For example 300px. We have two problems with this. Firstly, the breakpoint for the sidebar no longer works. Consequently, falling below the page width must be used for this breakpoint.
The calculation for the attributes left of the class .tc-sidebar-scrollable and .tc-story-river should be reviewed or calculated anew. The story must not be in the middle because otherwise the sidebar might fall out of the window on the righthand side. As far as the implementation is concerned, I don't yet know exactly where to change it because I don't yet know how all the elements are connected and which values have to be changed at which point. I tested these values using Mario's example <https://pmario.github.io/kitchensink/5800-centered-fluid-layout.html>, directly in the browser. By, Frank David Gifford schrieb am Donnerstag, 17. Juni 2021 um 14:55:08 UTC+2: > For reference, I am attaching images of what full screen and almost full > screen look like on my average-sized laptop, 15" screen. > > > > On Thursday, June 17, 2021 at 7:47:59 AM UTC-5 David Gifford wrote: > >> Feedback on this idea and the example link: >> >> 1. On my 15" laptop, the sidebar is way too scrunched to be useful. >> 2. When I reduced my browser window from full to about a centimeter less >> wide, it switches to "mobile" layout and the sidebar moves above the story >> river. >> 3. So #1 and #2 tell me this is a solution created for developers that >> have super wide screens, but not taking into account those of us with >> average sized screens. >> 4. If this were core, this would mean that upon upgrading, I would need >> to a) know what to do to fix it, and b) go in and do it. For every file I >> upgrade. This is not a "backwards-compatible" solution. It would be better >> to leave it as it has always been, with the original two options, and add >> this as a third option. But not make this third option default. >> 5. Your example takes away fixed story, fluid river, which is my default >> option. Are you proposing eliminating that option? >> 6. I did like someone's suggestion of "All centered". Then have a field >> to adjust the width of the margins, and a slider to adjust the %'s of story >> vs sidebar. But again, this should not be default, but a third option. >> >> On Thursday, June 17, 2021 at 6:48:31 AM UTC-5 PMario wrote: >> >>> I folks, >>> I did just upload a "test version" >>> https://pmario.github.io/kitchensink/5800-centered-fluid-layout.html >>> where you can play with. >>> >>> BUT >>> >>> It is a theme now. I did use the existing *Centralised *theme and >>> pimped it a bit. See the animated gif. >>> >>> [image: centered-fixed-02.gif] >>> >>> *What's new* >>> >>> - Every "Theme Tweaks" setting has a "Back to default" button now, >>> which should make it easy to undo experiments. >>> - The Centralised theme has less settings, which should make it >>> easier. >>> - Unused settings have been "grayed out" which should make >>> experimenting easier. >>> - The default value for Centralised "story width" is 900px >>> - The "width breakpoint" where it switches to "mobile mode" has been >>> set to 1260 >>> - Snowwhite and Vanilla also got the "gray out" functionality. >>> - There is a minimum width now. So if you set storywidth to a very >>> small value, you will still be able to see something >>> - min is 500px >>> >>> I needed to convert the settings into a theme, because the "Tight" and >>> "Tight and Heavier" theme cause problems, since they hardcoded margins and >>> paddings, which clashed with the centred setting. >>> >>> The PR is >>> >>> have fun! >>> mario >>> >>> -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/cf657489-b11b-4001-a4fb-e74bff757d15n%40googlegroups.com.
