I have confirmed that RHEL 4 doesn't have the
gnutls_transport_set_global_errno function:
g++ -DHAVE_CONFIG_H -I. -I/home/drc/worksrc/tigervnc/common/rdr -I../..
-I/home/drc/worksrc/tigervnc/common
-I/home/drc/worksrc/tigervnc/common/zlib -O3 -static-libgcc -fPIC -Wall
-MT librdr_la-TLSInStream.lo -MD -MP -MF .deps/librdr_la-TLSInStream.Tpo
-c /home/drc/worksrc/tigervnc/common/rdr/TLSInStream.cxx -fPIC -DPIC -o
.libs/librdr_la-TLSInStream.o
/home/drc/worksrc/tigervnc/common/rdr/TLSInStream.cxx: In function
`ssize_t rdr::gnutls_InStream_pull(void*, void*, size_t)':
/home/drc/worksrc/tigervnc/common/rdr/TLSInStream.cxx:42: error:
`gnutls_transport_set_global_errno' was not declared in this scope
/home/drc/worksrc/tigervnc/common/rdr/TLSInStream.cxx:42: warning:
unused variable 'gnutls_transport_set_global_errno'
/home/drc/worksrc/tigervnc/common/rdr/TLSInStream.cxx:46: warning:
comparison between signed and unsigned integer expressions
/home/drc/worksrc/tigervnc/common/rdr/TLSInStream.cxx:52: error:
`gnutls_transport_set_global_errno' was not declared in this scope
/home/drc/worksrc/tigervnc/common/rdr/TLSInStream.cxx:52: warning:
unused variable 'gnutls_transport_set_global_errno'
make[3]: *** [librdr_la-TLSInStream.lo] Error 1
However, when I attempted to apply the patch to work around this, I got
a worse build error:
gcc4 -DHAVE_CONFIG_H -I. -I/home/drc/worksrc/tigervnc/common/os -I../..
-I/home/drc/worksrc/tigervnc/common -O3 -static-libgcc -fPIC -Wall -MT
libos_la-net.lo -MD -MP -MF .deps/libos_la-net.Tpo -c
/home/drc/worksrc/tigervnc/common/os/net.c -fPIC -DPIC -o
.libs/libos_la-net.o
In file included from /usr/include/stdlib.h:33,
from /home/drc/worksrc/tigervnc/common/os/net.c:23:
/usr/lib/gcc/x86_64-redhat-linux5E/4.1.2/include/stddef.h:214: error:
expected '=', ',', ';', 'asm' or '__attribute__' before 'typedef'
In file included from /home/drc/worksrc/tigervnc/common/os/net.c:23:
/usr/include/stdlib.h:140: error: expected '=', ',', ';', 'asm' or
'__attribute__' before '__ctype_get_mb_cur_max'
In file included from /usr/include/sys/types.h:266,
from /usr/include/stdlib.h:433,
from /home/drc/worksrc/tigervnc/common/os/net.c:23:
/usr/include/bits/pthreadtypes.h:48: error: expected
specifier-qualifier-list before 'size_t'
In file included from /home/drc/worksrc/tigervnc/common/os/net.c:23:
/usr/include/stdlib.h:450: error: expected declaration specifiers or
'...' before 'size_t'
/usr/include/stdlib.h:480: error: expected declaration specifiers or
'...' before 'size_t'
/usr/include/stdlib.h:482: error: nonnull argument with out-of-range
operand number (argument 1, operand 4)
/usr/include/stdlib.h:584: error: expected ')' before '__size'
/usr/include/stdlib.h:586: error: expected ')' before '__nmemb'
/usr/include/stdlib.h:595: error: expected declaration specifiers or
'...' before 'size_t'
In file included from /usr/include/stdlib.h:606,
from /home/drc/worksrc/tigervnc/common/os/net.c:23:
/usr/include/alloca.h:33: error: expected ')' before '__size'
In file included from /home/drc/worksrc/tigervnc/common/os/net.c:23:
(and many many more)
On 9/3/10 12:53 AM, Martin Koegler wrote:
> On Thu, Sep 02, 2010 at 10:42:17AM +0200, Adam Tkac wrote:
>> On Thu, Sep 02, 2010 at 09:05:52AM +0200, Martin Koegler wrote:
>>> Signed-off-by: Martin Koegler <mkoeg...@auto.tuwien.ac.at>
>>> ---
>>> configure.ac | 2 ++
>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> May I ask you which version of GNUTLS is old, please? Did you check
>> this change doesn't break later gnutls_error_is_fatal/gnutls_strerror
>> calls?
>
> I tried compiling it on a system, which had the development file of
> gnutls 1.0.X installed (please don't ask why). With this change,
> vencrypt compiles and TLS connections are working.
>
> This patch restores the old vnecrypt behaviour, if GNUTLS is missing
> gnutls_transport_set_global_errno to avoid raising the minimal
> required GNUTLS version.
>
> After checking, when gnutls_transport_set_global_errno was introduced,
> please decide yourself, if support for older versions is really
> necessary.
>
> Regards,
> Martin Kögler
>
> ------------------------------------------------------------------------------
> This SF.net Dev2Dev email is sponsored by:
>
> Show off your parallel programming skills.
> Enter the Intel(R) Threading Challenge 2010.
> http://p.sf.net/sfu/intel-thread-sfd
> _______________________________________________
> Tigervnc-devel mailing list
> Tigervnc-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
