On 28/11/16 15:55, Jon Maloy wrote: >>> >>> The explanation is simple: the patch is not applied on net-next yet, only >>> on net. >> It normally takes a few days before David re-applies fixes to net back to >> net-next. >> Since you anyway checked out net-next, you could try to apply the patch >> yourself. >>> >> >> ok maybe my first e-mail was not clear enough. I applied your patch on top of >> 4.9.0-rc7 and it does not make a difference, thats what I am trying to say. >> It >> is still broken on my side. >> >> Best regards >> Holger > > Then I have no more theories. The patch works fine in my x64 environment, and > I see no reason it shouldn't work on PowerPC as well, since there are no > endianness operations involved. Is the output *exactly* the same before and > after having applied the patch? >
hm weird, I have currently no setup were I can doublecheck this on a x86 environment. The output differs, depending the patch is applied or not. Sending 150 packets with a size of 1000 bytes to the server leads to the following link statistic on the client side: With your patch: Link <broadcast-link> Window:50 packets RX packets:0 fragments:0/0 bundles:0/0 TX packets:1050 fragments:1050/150 bundles:0/0 RX naks:0 defs:0 dups:0 TX naks:0 acks:0 dups:0 Congestion link:46 Send queue max:0 avg:0 Link <1.1.4:eth2-1.1.211:eth1> ACTIVE MTU:1500 Priority:10 Tolerance:1500 ms Window:50 packets RX packets:5 fragments:0/0 bundles:0/0 TX packets:4 fragments:0/0 bundles:0/0 TX profile sample:2 packets average:60 octets 0-64:100% -256:0% -1024:0% -4096:0% -16384:0% -32768:0% -66000:0% RX states:544 probes:10 naks:0 defs:2 dups:2 TX states:548 probes:470 naks:2 acks:66 dups:0 Congestion link:0 Send queue max:0 avg:0 Without your patch: Link <broadcast-link> Window:50 packets RX packets:0 fragments:0/0 bundles:0/0 TX packets:0 fragments:0/0 bundles:0/0 RX naks:0 defs:0 dups:0 TX naks:0 acks:0 dups:0 Congestion link:49 Send queue max:0 avg:0 Link <1.1.4:eth2-1.1.211:eth1> ACTIVE MTU:1500 Priority:10 Tolerance:1500 ms Window:50 packets RX packets:0 fragments:0/0 bundles:0/0 TX packets:4 fragments:0/0 bundles:0/0 TX profile sample:2 packets average:60 octets 0-64:100% -256:0% -1024:0% -4096:0% -16384:0% -32768:0% -66000:0% RX states:397 probes:7 naks:0 defs:2 dups:2 TX states:400 probes:325 naks:2 acks:66 dups:0 Congestion link:0 Send queue max:0 avg:0 so in both cases no TX packets are accounted on the specific link, but with your patch something is counted on the account of the broadcast link. Best regards Holger ------------------------------------------------------------------------------ _______________________________________________ tipc-discussion mailing list tipc-discussion@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tipc-discussion
