On Sun, Jul 12, 2009 at 11:18 AM, Adrian Buehlmann<adr...@cadifra.com> wrote: > On 12.07.2009 18:17, Steve Borho wrote: >> On Sun, Jul 12, 2009 at 10:33 AM, Adrian Buehlmann<adr...@cadifra.com> wrote: >>> I hacked a bit on making it possible to switch off overlay icons >>> per repo (issue 382). >>> >>> The patches I have detect if .hg/thgstatus has '@@noicons' on the >>> first line and then the shell ext does not display any overlay >>> icons for that repo and thgtaskbar will not update the file >>> any more (on normal update requests). >>> >>> What's yet missing here is the ui to write/remove said @@noicons. >>> I'm a bit unusure where to integrate that. >>> >>> It would be best to introduce a new command for thgtaskbar, >>> so that thgtaskbar stays the one and only process that writes >>> .hg/thgstatus (shellext is reader only). Technically, it >>> would be trivial to send that from the shell ext. >>> Infrastructure to send that from a hgtk dialog would yet >>> have to be added though. >> >> I'm tempted to put the UI for it in the taskbar options tool since the >> taskbar app will be guaranteed to be running and it doesn't add a very >> rarely used command to the context menu. > > Problem is: how do you specify the repo there? > > The context menu has a context: the repo it acts upon.
We do have a directory browser, but your point is taken. There are trade-offs in all the approaches. Adding this to the context menu does have it's benefits, though we'll be once again scrambling for a new icon right before a release unless we can recycle an existing one. Adding a context menu option that doesn't result in a call to hgtk could be a little tricky to do cleanly. Did you have any ideas in mind? I still have one more tweak I would like to make to the shell context menu before 0.8.1 is released, but this shouldn't interfere with your changes (the datamine command in the no-files-selected menu needs different text than the files-selected menu since the behavior is quite different). >>> Another open question is: should this go into stable or >>> crew? >> >> This is technically a feature regression (it existed in 0.7 but not in >> 0.8), so a case could be made to apply it to stable. > > Ok. If you apply your patches to your stable repo I can pull them from there. We can work on the ui over the next few days. -- Steve Borho ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
