On 13.07.2009 06:09, Steve Borho wrote:
> We do have a directory browser, but your point is taken.  There are
> trade-offs in all the approaches.  Adding this to the context menu
> does have it's benefits, though we'll be once again scrambling for a
> new icon right before a release unless we can recycle an existing one.

Maybe this could be done with a checkmarked cmenu entry.

Not much point in adding an icon for such an entry then.

> Adding a context menu option that doesn't result in a call to hgtk
> could be a little tricky to do cleanly.  Did you have any ideas in
> mind?

Most ugliest thing would be that we would have to read .hg/thgstatus
in order to be able to tell whether there must be a checkmark or
not at the cmenu item.

Not that funny to implement. So maybe, deferring this for 0.9
or do some other quick interim solution like using the
directory browser, started from thgtaskbar.
But I'm not even sure if doing this would really be that much simpler
to implement.

> I still have one more tweak I would like to make to the shell context
> menu before 0.8.1 is released, but this shouldn't interfere with your
> changes (the datamine command in the no-files-selected menu needs
> different text than the files-selected menu since the behavior is
> quite different).
> 
>>>> Another open question is: should this go into stable or
>>>> crew?
>>> This is technically a feature regression (it existed in 0.7 but not in
>>> 0.8), so a case could be made to apply it to stable.
>> Ok.
> 
> If you apply your patches to your stable repo I can pull them from
> there.  We can work on the ui over the next few days.

Done. Pushed as
http://bitbucket.org/abuehl/thg-stable/changeset/d4bb3d7c4d60/
(lacks the ui, as advertised)

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Tortoisehg-develop mailing list
Tortoisehg-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop

Reply via email to