On 29.08.2009 05:21, Steve Borho wrote: > On Fri, Aug 28, 2009 at 4:57 PM, Adrian Buehlmann<adr...@cadifra.com> wrote: >> On 28.08.2009 23:52, Adrian Buehlmann wrote: >>> On 24.08.2009 19:05, Steve Borho wrote: >>>> On Mon, Aug 24, 2009 at 11:22 AM, Benjamin Pollack<benja...@fogcreek.com> >>>> wrote: >>>>> # HG changeset patch >>>>> # User Benjamin Pollack <benja...@fogcreek.com> >>>>> # Date 1251128738 14400 >>>>> # Node ID 2a8144b18f438cfd932f625463352a633db98370 >>>>> # Parent 2bc434de93336c91f081c333bb69b083f48d1f91 >>>>> thgconfig: fix typo >>>> Pushed, thanks. >>>> >>> Has this been included in a nightly? >>> >>> Or, asking the other way around: is this patch included in: >>> >>> http://bitbucket.org/tortoisehg/thg-winbuild/downloads/TortoiseHg-Nightly-090827.exe >>> >>> Or, asking yet another way: >>> >>> What revision of TortoiseHg was used to build TortoiseHg-Nightly-090827.exe? >>> >>> I would like to try out an installer that contains this patch, but I don't >>> know >>> what TortoiseHg-Nightly-090827.exe contains. >>> >>> What revision of http://bitbucket.org/tortoisehg/thg-winbuild >>> was used to build TortoiseHg-Nightly-090827.exe? >>> >>> I would like to know what exactly I'm gonna test if I install >>> TortoiseHg-Nightly-090827.exe (before I do so, I haven't done yet). >> Apologies, I picked the wrong email to respond to. >> >> What I wanted to try out installing was: >> >> [thg-dev] [PATCH] installer: automatically terminate taskbar process > > > That change is in the latest nightly. I tested it on a few computers > and it seems to do the right thing. If the installing user is the > only one logged in, it quietly closes the taskbar app and finishes the > install. If another user was logged in, it shows a warning about not > being able to shutdown tortoisehg, and allows them to cancel or retry. > > The warning message could probably be improved, but the functionality > seems correct.
Ok. Latest nightly as of writing this seems to be TortoiseHg-Nightly-090827.exe (looking at http://bitbucket.org/tortoisehg/thg-winbuild/downloads/ right now). The test case I had in mind is about the following scenario: A user is logged-in as normal user 'x' (not a member of the administrators group), having the thgtaskbar.exe running. Then that user x decides to install a new version of TortoiseHg. He starts the installer by holding down the shift key on the keyboard and clicking the right mouse button while pointing at the installer exe, then chooses "Run as..." from the context menu that is presented ("Run as..." appears only when shift-right-clicking). In the dialog appearing, he chooses the administrator account to run the exe, and enters the password for that login. This is in fact how I mostly install software myself, since I don't want to be logged in as an admin on a Windows XP system while surfing The Evil Net. But I don't want to log out just to install a software component. The question I had is: The patch seems to be going fishing for the thgtaskbar's window and closes it. Does that work in this use case? Maybe I'll try testing that during the day... BTW, it would really be helpful if we knew in advance what a nightly contains. That would increase my motivation to test them significantly. Maybe you could note on a wiki page what exact revisions of the repositories you used when building the installer? As it currently is, nightlies are a bit of a black box. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
