On Tue, Feb 10, 2009 at 10:40 PM, TK Soh <[email protected]> wrote: > On Wed, Feb 11, 2009 at 4:32 AM, Steve Borho <[email protected]> wrote: >> On Wed, 2009-02-11 at 04:23 +0000, TK Soh wrote: >>> On Wed, Feb 11, 2009 at 4:04 AM, Steve Borho <[email protected]> wrote: >>> > On Wed, 2009-02-11 at 03:39 +0000, TK Soh wrote: >>> >> >> > Partially selected files are now visually noticeable in two ways. >>> >> >> > The >>> >> >> > 'inconsistent' state in the file list now works correctly, on >>> >> >> > Windows >>> >> >> > the box is filled in like in a multiple choice exam. Also, the file >>> >> >> > diff header has the tag '** Partial **' added to it. Let me know >>> >> >> > what >>> >> >> > you think about this as well (is the text tag in the right place?) >>> >> >> >>> >> >> When a file is partial, it's associated file-list checkbox is >>> >> >> disabled. It should be checked, but with some visual cue to indicate >>> >> >> partial selection, or, errr, rejection. >>> >> > >>> >> > The checkbox is marked as 'inconsistent', but it's still enabled. >>> >> > Having three states for the check box seems the best visual clue: >>> >> > >>> >> > checked - entire file is selected >>> >> > inconsistent - part of file is selected >>> >> >>> >> What does 'inconsistent' look like graphically? >>> > >>> > On Windows it shows the checkbox filled in with a slightly smaller solid >>> > box. >>> >>> I don't see it on my Windows box with PyGTK 2.10.6. Does it need a >>> newer version? >> >> Perhaps. I had to rebuild my windows box recently, so I downloaded the >> latest packages off their website. You mentioned you were having >> problems with the file selection dialog with newer versions. What were >> those problems? I should verify I don't have them. > > If indeed the 'inconsistent' checkbox required the latest version of > pygtk, then it's probably not a very good idea to use it, as many > systems out there may be forced to stay with older versions.
The docs say it requires GTK+ 2.2. I don't think that's the issue. I did notice that the default style on Ubuntu does not visualize the inconsistent state at all. I had to switch to another desktop style to see it. Ok, what can we use in addition to the inconsistent state? BTW: I've just pushed enough changes to thg-crew-steve to implement the selection indication you suggested. The color is removed and an italic font is used. I also tried lowering the weight, but this seems to be ignored on our default font. For good measure, I made the background a little darker. Have a look and let me know what you think. On Windows, the hunk size seems to change slightly when you toggle it but it's much less than how it used to be. I didn't try toggling the text foreground color. That may have a nice effect. -- Steve ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ Tortoisehg-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss
