On Thu, 2009-02-12 at 01:31 +0000, TK Soh wrote: > On Thu, Feb 12, 2009 at 1:11 AM, Steve Borho <[email protected]> wrote: > > On Wed, Feb 11, 2009 at 5:53 PM, TK Soh <[email protected]> wrote: > >> On Wed, Feb 11, 2009 at 11:48 PM, Steve Borho <[email protected]> wrote: > >>> The nightly builds install over the top of 0.6 without requiring an > >>> uninstall to happen first. Whatever hack TK put into the 0.6 > >>> installer to require the uninstall/reboot step hasn't made it back > >>> into the tip installer scripts. > >> > >> Do you mean it's not in the installer patch queue I published on freehg? > > > > The forest installer branched away from the pure-MQ based > > method a couple weeks before 0.6 was released. Changes pushed > > to your repo after that point have not been merged back. > > > > stuff that's on freehg is hard to find, what's your URL again? > > You can look under my collection (should be easy to remember the URL > syntax for freehg) > > http://freehg.org/u/tksoh/
Bookmarked it, thanks. That change you made was the only one that we didn't already have. I'll probably use something similar for 0.7. > >>> I'm ok with a release note to tell people to uninstall 0.4 or earlier > >>> before installing 0.7. > >> > >> We have done that before, but not everyone remember (or willing?) to > >> do that. That's why we force them to uninstall before upgrade to 0.6. > > > > What's the consequences again if they do not uninstall 0.4 first? > > Does it leave the shell/registry totally confused? > > Thg < 0.5 use a different set of registry keys for overlay icons, > which needs to be removed since we are not using the new ones to share > with TortoiseOverlays.dll. > > > We've got a few weeks, I'd rather fix this by refusing to install if > > <=0.4 is found, if possible. I see in the M/L history Peer had a patch > > for some of this, but I can't get it out of gmail anymore. Do you > > still have that patch, Peer? > > > > 0.7 over the top of >= 0.5 should work flawlessly, and I would like > > to limit the baggage we carry forward. > > It seems that way when I tried last time, but I haven't seen any > official document to guarantee that behavior. The core of the issue is > that Windows can only remove/replace files that are not in used, > that's why need to unregister and restart Explorer to detach it from > tortoisehg.dll - at least on version < 0.5. > > I suspect the use of TortoiseOverlays.dll somehow changed that, but > then again, I don't have the official statement. I think there's two general issues involved. If we're upgrading over the top of an existing install, then we need to reboot in order to overwrite files that Explorer keeps open (mostly DLLs). And for versions <0.5, we must unregister the old overlays because versions >=0.5 use a completely different mechanism. If we're upgrading into a different location from the original install, the file write issues would be all gone, but we would still need to uninstall the old version to unregister the shell extensions. Else we would have two versions of tortoisehg.dll installed after the reboot, which would lead to hilarity, I'm sure. So we must uninstall the old version of TortoiseHg if it's <0.5 (because of the overlay change) or if we're installing into a different location (because the location of tortoisehg.dll is stored in the registry). To be safe, I think it makes sense for 0.7 to again require an uninstall of any previous version. By 0.8, I hope to move to WIX to generate an MSI installer and for the installer to have the intelligence to detect either of the failure cases and prevent them. In theory, a future upgrade of THG would only require a restart of explorer.exe if the upgrade were 'in place'. -- Steve ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ Tortoisehg-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss
