Hey :),

On Sun, May 21, 2017 at 11:35 PM, Sam Thursfield <sss...@gmail.com> wrote:
> On 5/21/17, Carlos Garnacho <carl...@gnome.org> wrote:
>> On Thu, Mar 30, 2017 at 11:54 PM, Sam Thursfield <sss...@gmail.com> wrote:
>> FWIW, the meson step fails here because I lack the gee library, which
>> we don't need anymore :), those bits can be removed from the root dir
>> and utils/tracker-resdump meson.build files.
>
> OK, done.
>
>>> You can run the test suite:
>>>
>>>     ninja-build test
>>
>> Hmm, amusingly "ninja test" fails on some tests in weird ways here. I
>> must investigate further, but won't make this hold the merge.
>
> Interesting .. I see some failures as well. I'll see if I can solve
> any. The functional tests mostly fail but that's been the case anyway,
> it's just that previously they weren't run unless you manually did
> `make functional-test`.

Right, most failing tests are the functional ones. I'm more baffled at
the tracker-steroids test timing out here. Running it manually leaves
it stuck awaiting for the reply of the first update, while the
autotools generated one just succeeds.

Hopefully functional tests will get better when we have
domain-ontologies in place :).

>
>> As long as autotools config is preserved so far, I think this can be
>> merged soon so it gets more coverage through jhbuild/whatnot. At a
>> later point we can definitely consider going meson-only :).
> ...
>>
>> Please let's get this merged ASAP :), I think it looks and works good
>> enough that we get further coverage.
>
> I've pushed a new 'meson-final' branch with everything in single
> commit; I can merge this tomorrow if you're happy with it.

Go go go! I guess we'll have to do
https://mail.gnome.org/archives/desktop-devel-list/2017-April/msg00091.html
before the next release, but I can go ahead after you merge it.

Cheers,
  Carlos
_______________________________________________
tracker-list mailing list
tracker-list@gnome.org
https://mail.gnome.org/mailman/listinfo/tracker-list

Reply via email to