On 2/26/07, Allan N. Snider <[EMAIL PROTECTED]> wrote:
Attached is a patch (against v1.1.0), that makes a minor change to
the argument parsing code. When the parameter(s) of a filter argument are
retrieved the code skips past the argument name plus one character, which it
assumes is the '=' sign. I modified it to only skip the '=' if it is in
fact an equal sign. When this is done, it allows a more convenient form for
optional string values ("%s"), for example:
-J filter=arg[=string]
I can do a lookup on arg and provide a default if no value is present, or
use the provided string. Without the patch, a statement like '-J
filter=arg1:arg2', would yeild arg2 as the string value for arg1.
I don't think this change has any other side affect. It's aesthetically
more pleasing then having to write:
-J filter=arg1=:arg2
I'm fine with the concept and the code looks OK. I'd like to add some (more
tests) before/just after the commit.
I'm *really* out of time on those days (and I'also implementing input
rotation, more details ASAP), so unfortunately we must keep this on hold.
Again.
I'm sorry, but that's it :(
Bests,
--
Francesco Romani
