On 3/12/07, Allan N. Snider <[EMAIL PROTECTED]> wrote:
Francesco, Andrew:
I've made one additional small change. There was a problem when using
optstr_get() on the last argument of a filter line. Normally, optstr_get()
returns -1 if the option was NOT present, 0 if present without any (valid)
argument given, or > 0 as the number of values provided. My option parsing
depends upon this behavior, but unfortunately for the last argument, a zero
length string is passed off to scanf() resulting in -1 returned, even though
the argument was supplied. I have added one small check to just return
zero, instead of passing scanf() an empty string. I've tested it and it
seems to work fine.
No objections at first glance, but I still feel the need of an automatic
testsuite for optstr* stuff in testsuite/.
I'll add this task to my TODO list.
best regards,
--
Francesco Romani
