On 07 Feb 18:13, Sergi Almacellas Abellana wrote: > El 07/02/15 a les 09:24, Cédric Krier ha escrit: > >On 07 Feb 12:34, Sharoon Thomas wrote: > >>>On 02/06, Sergi Almacellas Abellana wrote: > >>>> >Hi, > >>>> > > >>>> >As a PoC i just added flake8 check to tox [1] on one of my personal > >>>> >projects. The output is available on drone [2]. > >>>> > > >>>> >I tought it my be interesting to have this check also on all tryton > >>>> >modules. > >>>> >What do you think? . > >>> > >>>We at Openlabs have been using this for our modules since 2 years. > >>>Having a check on Flake8 brings consistency to the codebase and makes it > >>>easier for new contributors to understand the coding standards expected > >>>instead of a human doing it. > >We already have it on codereview so nothing new. > >And such check in after commit is just too late. > > I propose it because i imagine that some point in the future we will have > tests run on codereview so it's easier to have all information in one place.
As far as there is not correct coverage support in drone, for me it is useless. https://github.com/drone/drone/issues/440 https://github.com/drone/drone/issues/239 > >>>> >Also this will allow to deprecate reviewbot once all codereviews are > >>>> >tested > >>>> >on drone. > >>>Having flake8 tests on CI is certainly better than having it on the review > >>>tool. > >No, it is too late and false positive will be such a pain. > >More over, our reviewbot is doing a great job by commenting inline > >flake8 issues instead of having a plain report somewhere else. > > But it also reports false positives (unchanged code), so it's the same > problem. When I talk about false positive, I talk about CI failure because of flake8 issue or wrong interpretation or coding exception etc. Of course, it is a little bit annoying to have false positive with reviewbot but I don't think it is possible to improve it because some "non-changed line" comment could be valid comment. I just wanted to say that having it inlineis much better than a plain report somewhere else. -- Cédric Krier - B2CK SPRL Email/Jabber: cedric.kr...@b2ck.com Tel: +32 472 54 46 59 Website: http://www.b2ck.com/
