At the risk of throwing stones in a glass house (since I forget to set svn ignore), *please* remember to run mvn -Psourcecheck prior to checkins for Java SCA. The Checkstyle audit raises a significant number of formatting errors that are trivial to avoid by setting templates in an IDE.

More importantly, PMD fails the build, which is generally a sign of a potential problem in code. For example, JavaLoggingMonitorFactory fails with a PMD violation. In this case, it's because the constructor calls out to an overridable method, which is a bad thing.

There are various areas of the build that are in a state of disrepair. Can people please clean these up as soon as possible?

Jim

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to