On 12 June 2016 at 21:32, Itamar Turner-Trauring <ita...@itamarst.org> wrote:
> Hi all, > > Since we're starting to get PRs from random people it's worth trying to > make the process as friendly as possible. > > So, maybe instead of telling new contribtutors "PRs won't be reviewed > without an issue, see contributor guidelines" it would be better to say > "Thanks for the PR! I opened an issue for this PR here (tm.tl/12345). In > the future we'd appreciate it if you could open an issue before submitting > PRs; see contributor guidelines for details". > > If someone went out of their way to provide a fix, we should try to > minimize any unnecessary stop-energy they encounter along the way, even if > that means some people won't learn the intricacies of the process. > > Beside the fix, we need tests, documentation, release notes fragment.... sometimes compatibility with python 2 and python3... so I would say that Twisted is not designed for low-energy contributors. I would like to thank Craig for monitoring the Twisted PR. For low-energy dudes, like me, it is of great help as I am only monitoring the Twisted's official review queue (https://twistedmatrix.com/trac/report/25) which is already huge. Thanks again Craig and keep up the good work ! :) -- Adi Roiban
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python