On Fri, May 13, 2016 at 3:46 PM, Kevin Hilman <khil...@baylibre.com> wrote: > Carlo Caione <ca...@caione.org> writes: > >> From: Carlo Caione <ca...@endlessm.com> >> >> This is a port / rewrite of the Amlogic driver shipped whithin the >> Amlogic SDK for the Meson GXBaby (S905) SoC. >> >> Signed-off-by: Carlo Caione <ca...@endlessm.com> > > [...] > >> +static const struct udevice_id meson_mmc_match[] = { >> + { .compatible = "amlogic,meson-mmc" }, >> + { /* sentinel */ } > > IIUC, this controller is different between meson8* and gxbb. If that's > the case, this compatible should probably be more specific.
Yes, this is a point I raised also on lkml when I submitted the MMC driver for the Meson8b. Since the registers mapping is different I assume that this is the case. Just to be sure, given that you are the only one with a datasheet for the GXBB, can you confirm that? Actually for the same reason I was in doubt if CONFIG_MMC_MESON was a right naming choice here, but since it is really unlikely that we will ever see a U-Boot port for the Meson8b I stuck with that. Cheers, -- Carlo Caione _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot