Hi Becky, > +/* Common ddr init for non-corenet fsl 85xx platforms */ > +#ifndef CONFIG_FSL_CORENET > +phys_size_t initdram(int board_type) > +{ > + phys_size_t dram_size = 0; > + > + puts("Initializing\n");
Any chance we can remove the puts() above? "DRAM:" is always printed out directly before initdram is called, so I don't think the "Initializing" message adds much benefit and slightly dirties the output. For reference: I2C: ready DRAM: Initializing DDR: 2 GiB (DDR2, 64-bit, CL=5, ECC on) FLASH: Executed from FLASH1 FLASH: 256 MiB vs I2C: ready DRAM: DDR: 2 GiB (DDR2, 64-bit, CL=5, ECC on) FLASH: Executed from FLASH1 FLASH: 256 MiB Otherwise it looked good. I tested on the xpedite5170 that was a corner case, and the xpedite5370 (mpc8572-based). Acked-by: Peter Tyser <pty...@xes-inc.com> Tested-by: Peter Tyser <pty...@xes-inc.com> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot