Am 8. Juli 2022 11:45:54 MESZ schrieb Paul Barker <paul.bar...@sancloud.com>:
>I'm looking for some initial feedback on the following patches which add 
>support
>for the UEFI SPI I/O protocol defined in the UEFI Platform Initialization (PI)
>Specification, Version 1.7 Errata A (April 2020). I'd like to know if the
>overall approach is acceptable for inclusion in u-boot and if you have any
>questions or can spot any implementation issues at this stage. I'm planning to
>follow up with a v2 series addressing any feedback and adding test cases.

Hello Paul,

up to now U-Boot does not implement any part of the PI specification. Please, 
explain why we should implement this protocol.

For all EFI protocols there should be a test that can be run in our Gitlab CI 
showing that it is working correctly.

Best regards

Heinrich

>
>Paul Barker (2):
>  efi_loader: Add SPI I/O protocol support
>  arm: dts: am335x-sancloud-bbe-lite: UEFI SPI export
>
> MAINTAINERS                               |   6 +
> arch/arm/dts/am335x-sancloud-bbe-lite.dts |   8 +-
> include/efi_loader.h                      |   4 +
> include/efi_spi_protocol.h                | 158 ++++++
> lib/efi_loader/Kconfig                    |   8 +
> lib/efi_loader/Makefile                   |   1 +
> lib/efi_loader/efi_setup.c                |   6 +
> lib/efi_loader/efi_spi_protocol.c         | 565 ++++++++++++++++++++++
> 8 files changed, 754 insertions(+), 2 deletions(-)
> create mode 100644 include/efi_spi_protocol.h
> create mode 100644 lib/efi_loader/efi_spi_protocol.c
>
>

Reply via email to