On 11/07/2022 14:12, Ilias Apalodimas wrote:
Hi Paul

+static efi_status_t
+efi_spi_bus_clock(const struct efi_spi_peripheral *spi_peripheral,
+                 u32 *clock_hz)
+{
+       EFI_ENTRY("%p, %p", spi_peripheral, clock_hz);
+       return EFI_EXIT(EFI_UNSUPPORTED);
+}
+

All the EFI_ENTRY/EXIT calls should be on functions marked as EFIAPI.
Most of the functions you use it on seem to be static function that
will never be called by an EFI application.

These functions are actually exported as part of EFI protocols and so can be called by an EFI application. So I should mark them as EFIAPI when I send v2 of this series.

Thanks,

--
Paul Barker
Principal Software Engineer
SanCloud Ltd

e: paul.bar...@sancloud.com
w: https://sancloud.com/

Attachment: OpenPGP_0xA67255DFCCE62ECD.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

Reply via email to