> -----邮件原件----- > 发件人: Quentin Schulz <[email protected]> > 发送时间: 2025年12月16日 17:50 > 收件人: Alice Guo (OSS) <[email protected]>; dl-uboot-imx > <[email protected]>; [email protected] > 抄送: Stefano Babic <[email protected]>; Fabio Estevam > <[email protected]>; Tom Rini <[email protected]>; Marek Vasut > <[email protected]>; Marek Vasut <[email protected]>; Ye Li > <[email protected]>; [email protected]; Peng Fan <[email protected]>; > Mattijs Korpershoek <[email protected]>; Lukasz Majewski > <[email protected]>; Sherry Sun <[email protected]>; Kever Yang > <[email protected]>; Jonas Karlman <[email protected]>; George > Chan <[email protected]>; Simon Glass <[email protected]>; David Zang > <[email protected]>; Alice Guo <[email protected]> > 主题: Re: [PATCH v1 5/7] usb: Kconfig: imply DM_USB_GADGET > > Hi Alice, > > On 12/16/25 7:38 AM, [email protected] wrote: > > From: Sherry Sun <[email protected]> > > > > Since the ci_udc driver has been converted to DM driver, the > > CONFIG_DM_USB_GADGET should also be selected when CONFIG_CI_UDC is > > enabled, then we can use DM ci_udc driver. > > > > Is DM_USB_GADGET *required* for CI_UDC to work? "imply" allows to have > DM_USB_GADGET=y AND CI_UDC=n, which is probably not what you want. You > probably simply want "depends on DM_USB_GADGET"
There are 2 implementations supported in drivers/usb/gadget/ci_udc.c: a non-DM path and a DM-based path. The current commit log wording might be ambiguous. > > Signed-off-by: Sherry Sun <[email protected]> > > Signed-off-by: Alice Guo <[email protected]> > > Reviewed-by: Ye Li <[email protected]> > > Please do not provide Reviewed-by on the first version of a patch, > Reviewed-by, > Acked-by, Tested-by, etc.... should be given publicly on the mailing list. We > don't > know if Ye Li actually reviewed it or if you unilaterally decided they > reviewed it. > We don't know if we can trust it... which we shouldn't have to figure out. The Reviewed-by tag was added during our internal review process. I will remove it in the next version. Best Regards, Alice Guo
