> -----邮件原件----- > 发件人: Marek Vasut <[email protected]> > 发送时间: 2025年12月16日 19:18 > 收件人: Alice Guo (OSS) <[email protected]>; dl-uboot-imx > <[email protected]>; [email protected] > 抄送: Stefano Babic <[email protected]>; Fabio Estevam > <[email protected]>; Tom Rini <[email protected]>; Marek Vasut > <[email protected]>; Marek Vasut <[email protected]>; Ye Li > <[email protected]>; [email protected]; Peng Fan <[email protected]>; > Mattijs Korpershoek <[email protected]>; Lukasz Majewski > <[email protected]>; Sherry Sun <[email protected]>; Kever Yang > <[email protected]>; Jonas Karlman <[email protected]>; Quentin > Schulz <[email protected]>; George Chan <[email protected]>; > Simon Glass <[email protected]>; David Zang <[email protected]>; Alice > Guo <[email protected]> > 主题: Re: [PATCH v1 3/7] usb: ehci-mx6: Extract PHY initialization into reusable > function > > On 12/16/25 7:38 AM, [email protected] wrote: > > From: Alice Guo <[email protected]> > > > > Extract USB PHY initialization code from ehci-mx6.c into a new > > function > > ehci_mx6_phy_init() that can be shared with the ChipIdea UDC driver. > > > > Signed-off-by: Alice Guo <[email protected]> > > --- > > drivers/usb/host/ehci-mx6.c | 73 > ++++++++++++++++++++++++++++++++++++++++++++- > > include/usb/ci_udc.h | 9 ++++++ > > 2 files changed, 81 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c > > index 03ff4ce10d5..52f14e6eca0 100644 > > --- a/drivers/usb/host/ehci-mx6.c > > +++ b/drivers/usb/host/ehci-mx6.c > > @@ -12,6 +12,7 @@ > > #include <asm/global_data.h> > > #include <linux/compiler.h> > > #include <linux/delay.h> > > +#include <usb/ci_udc.h> > > #include <usb/ehci-ci.h> > > #include <asm/io.h> > > #include <asm/arch/imx-regs.h> > > @@ -168,6 +169,54 @@ static void __maybe_unused > > usb_power_config_mx7ulp(void *usbphy) { } > > #endif > > > > +#if defined(CONFIG_IMX8) > > Can we avoid more ifdeffery ?
Thanks for your feedback. I will remove it in the next version. Best Regards, Alice Guo
