On Wed, Feb 25, 2026 at 09:23:45AM -0700, Simon Glass wrote: > From: Simon Glass <[email protected]> > > This function is useful for other scripts, so add a parameter to specify > the image name, if desired. > > Also add a flag to quieten the output of some of the tools, since in > many cases we only want to see warnings / errors.
Please stop doing "also ..." changes. One logical change per patch,
throughout.
[snip]
> - fs_img = f'{prefix}.{fs_type}.img'
> - fs_img = os.path.join(config.persistent_data_dir, fs_img)
> + if not fs_img:
> + leaf = f'{prefix}.{fs_type}.img'
> + fs_img = os.path.join(config.persistent_data_dir, leaf)
This is wrong (and would need to be reworked again in later parts of the
patch). We must ensure the image goes under the persistent data dir, but
we can allow the final name to be passed, if that's actually useful
anywhere (which I'm not sure it is).
--
Tom
signature.asc
Description: PGP signature
